#1090: Notification to the consumer when the product is back in stock #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Mar 10, 2024
| <div class="back-in-stock-subscribe"> | ||
| <form action="api/stocks/back-in-stock"> | ||
| <div> | ||
| @if (SignInManager.IsSignedIn(User)) |
There was a problem hiding this comment.
Suggested change
| @if (SignInManager.IsSignedIn(User)) | |
| @if (User.Identity.IsAuthenticated) |
Comment on lines
+36
to
+40
| public string GetCurrentHostName() | ||
| { | ||
| return _httpContext.Request.Host.Value; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| public string GetCurrentHostName() | |
| { | |
| return _httpContext.Request.Host.Value; | |
| } | |
| public string GetCurrentHostName() => _httpContext.Request.Host.Value; | |
Comment on lines
+147
to
+149
| if (await _backInStockSubscriptionRepository.Query() | ||
| .Where(o => o.ProductId == productId && o.CustomerEmail == customerEmail) | ||
| .AnyAsync()) |
There was a problem hiding this comment.
Suggested change
| if (await _backInStockSubscriptionRepository.Query() | |
| .Where(o => o.ProductId == productId && o.CustomerEmail == customerEmail) | |
| .AnyAsync()) | |
| if (await _backInStockSubscriptionRepository.Query() | |
| .AnyAsync(o => o.ProductId == productId && o.CustomerEmail == customerEmail)) |
|
|
||
| namespace SimplCommerce.Module.Inventory.Event | ||
| { | ||
| public class BackInStock : INotification |
There was a problem hiding this comment.
ProductBackInStock might more meaningful
Comment on lines
+16
to
+19
| public BackInStockSendEmailHandler(IStockSubscriptionService stockSubscriptionService) | ||
| { | ||
| _stockSubscriptionService = stockSubscriptionService; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public BackInStockSendEmailHandler(IStockSubscriptionService stockSubscriptionService) | |
| { | |
| _stockSubscriptionService = stockSubscriptionService; | |
| } | |
| public BackInStockSendEmailHandler(IStockSubscriptionService stockSubscriptionService) | |
| => _stockSubscriptionService = stockSubscriptionService; |
Comment on lines
+21
to
+24
| public async Task Handle(BackInStock notification, CancellationToken cancellationToken) | ||
| { | ||
| await _stockSubscriptionService.BackInStockSendNotificationsAsync(notification.ProductId); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public async Task Handle(BackInStock notification, CancellationToken cancellationToken) | |
| { | |
| await _stockSubscriptionService.BackInStockSendNotificationsAsync(notification.ProductId); | |
| } | |
| public async Task Handle(BackInStock notification, CancellationToken cancellationToken) | |
| => await _stockSubscriptionService.BackInStockSendNotificationsAsync(notification.ProductId); |
| { | ||
| public class BackInStockSubscription : EntityBase | ||
| { | ||
| public long ProductId { get; set; } |
There was a problem hiding this comment.
Suggested change
| public long ProductId { get; set; } | |
| public long ProductId { get; set; } | |
| @@ -12,6 +16,9 @@ public class ModuleInitializer : IModuleInitializer | |||
| public void ConfigureServices(IServiceCollection serviceCollection) | |||
| { | |||
| serviceCollection.AddTransient<IStockService, StockService>(); | |||
| serviceCollection.AddTransient<IStockSubscriptionService, StockSubscriptionService>(); | |||
| serviceCollection.AddTransient<INotificationHandler<BackInStock>, BackInStockSendEmailHandler>(); | |||
|
|
|||
| @@ -44,6 +48,8 @@ public async Task UpdateStock(StockUpdateRequest stockUpdateRequest) | |||
| var product = await _productRepository.Query().FirstOrDefaultAsync(x => x.Id == stockUpdateRequest.ProductId); | |||
| var stock = await _stockRepository.Query().FirstOrDefaultAsync(x => x.ProductId == stockUpdateRequest.ProductId && x.WarehouseId == stockUpdateRequest.WarehouseId); | |||
|
|
|||
| var prevStockQuantity = product.StockQuantity; | |||
|
|
|||
| }; | ||
|
|
||
| _backInStockSubscriptionRepository.Add(subscription); | ||
| await _backInStockSubscriptionRepository.SaveChangesAsync(); |
There was a problem hiding this comment.
Suggested change
| await _backInStockSubscriptionRepository.SaveChangesAsync(); | |
| await _backInStockSubscriptionRepository.SaveChangesAsync(); |
|
@thiennn I suggested some improvements to this PR also, there 're some non meaningful names, but seems you ignored all the my code suggestions |
|
@hishamco I can make your improvements in the new PR |
|
Believe it or not, it doesn't require a new PR, that's why the reviewing is helpful otherwise it's a waste of time if no one consider it Don't get me wrong |
|
No problem it happens :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1090 Implementation