Avoid product quantity overflow (#1113)

simplcommerce · Dec 21, 2024 · e42ceaa · e42ceaa
1 parent 230310c
commit e42ceaa
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/src/Modules/SimplCommerce.Module.ShoppingCart/Services/CartService.cs b/src/Modules/SimplCommerce.Module.ShoppingCart/Services/CartService.cs
@@ -47,7 +47,13 @@ public async Task<AddToCartResult> AddToCart(long customerId, long productId, in
                 return addToCartResult;
             }
 
+            if (quantity > int.MaxValue)
+            {
+                return CreateQuantityOverflowError();
+            }
+
             var cartItem = await _cartItemRepository.Query().FirstOrDefaultAsync(x => x.ProductId == productId && x.CustomerId == customerId);
+
             if (cartItem == null)
             {
                 cartItem = new CartItem
@@ -63,13 +69,27 @@ public async Task<AddToCartResult> AddToCart(long customerId, long productId, in
             }
             else
             {
+                if (cartItem.Quantity + quantity > int.MaxValue)
+                {
+                    return CreateQuantityOverflowError();
+                }
+
                 cartItem.Quantity = cartItem.Quantity + quantity;
             }
 
             await _cartItemRepository.SaveChangesAsync();
 
             addToCartResult.Success = true;
+
             return addToCartResult;
+
+            AddToCartResult CreateQuantityOverflowError()
+            {
+                addToCartResult.ErrorMessage = _localizer["The quantity must be larger than zero"].Value;
+                addToCartResult.ErrorCode = "wrong-quantity";
+
+                return addToCartResult;
+            }
         }
 
         // TODO separate getting product thumbnail, varation options from here