fix: Events not being triggered on last element deselection #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwep
force-pushed
the
fix-events-not-triggered-on-deselect
branch
from
b1fde7e to
8c562b2
Compare
simonwep
force-pushed
the
fix-events-not-triggered-on-deselect
branch
from
8c562b2 to
f7b66a6
Compare
|
I took another look at it and I think you're right, I believe that was just a short-thought optimization skipping the rest if the query yields no elements, decided to integrate that now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
This PR removes an
ifstatement that blockedmoveandstopevents from being triggered because there were no more selected elements.Steps to reproduce:
Check the
stopevent containing nostoredelements isn't triggered.