Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add turkish language #40

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: add turkish language #40

merged 1 commit into from
May 20, 2024

Conversation

TaylanTatli
Copy link
Contributor

No description provided.

@simonwep simonwep self-requested a review May 12, 2024 08:05
Copy link
Owner

@simonwep simonwep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for your contribution :)

  • Please use conventional commit messages, e.g. feat: add turkish language instead of "Add Turkish Language" :)
  • Keep the same order of keys in tr.json as compared to the other files. Makes it easier to review.
  • Run the test:ci script locally, I'm not sure why the build job in the workflow wasn't triggered by your PR. But the build fails.

@TaylanTatli TaylanTatli changed the title Add Turkish Language feat: add turkish language May 12, 2024
@TaylanTatli TaylanTatli requested a review from simonwep May 12, 2024 12:25
@TaylanTatli
Copy link
Contributor Author

I did everything you told me. It should be good to go. But I forced pushed to commit to change last commit. I don't know what to do about this requested changes. I don't have much knowledge about Git.

@simonwep
Copy link
Owner

I did everything you told me. It should be good to go. But I forced pushed to commit to change last commit. I don't know what to do about this requested changes. I don't have much knowledge about Git.

Hey, no problem. You can just check the checkboxes I made - I did that for you in this case. I'm working on contributing guidelines, so don't worry. I checked out your PR, rebased it and fixed a small bug with _numberFormats, you didn't have to translate that part :)

I'll merge yours in the coming day. Thank you for your contribution ❤️

@simonwep simonwep merged commit c71bcf6 into simonwep:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants