Fix parsing of committed datatype metadata with h5wasm #1708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wrongly calling
get_dataset_metadata
instead ofget_datatype_metadata
on committed datatypes.But
get_datatype_metadata
(and laterget_attribute_names
) had issues of their own, which are now fixed in https://github.com/usnistgov/h5wasm/releases/tag/v0.7.7 and https://github.com/usnistgov/h5wasm/releases/tag/v0.7.8I'm also making use of the new
Module#open
andModule#close_file
methods to avoid using the low-levelccall
method, and I refactor the h5wasm demo to allow dropping a new file on top of the viewer (like in myHDF5) so I can make sure that the clean-up effects of the providers do callclose_file
as expected.