-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ignore_menuitem
into LeftAndMain
#1846
Adding ignore_menuitem
into LeftAndMain
#1846
Conversation
604b752
to
32730a8
Compare
This is aimed to fix it in the main branch, happy to rebase it to another if needed. It could be also implemented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. You've got the correct branch - new API definitions belong in minor releases, and the 2
branch represents the April 2025 minor release currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this.
Will merge once CI has finished running and goes green.
There's a linting failure related to your change. Can you please resolve that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this.
Description
Adds the configuration
ignore_menuitem
into LeftAndMain so that anyone looking at the class will knows that this configuration exists. This will also now show up in the API docs (I think).Issues
Pull request checklist