ENH Update code to reflect changes in template layer #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
23 tasks
GuySartorelli
force-pushed
the
pulls/3/template-engine
branch
5 times, most recently
from
e70be94
to
ab8be54
Compare
GuySartorelli
force-pushed
the
pulls/3/template-engine
branch
from
ab8be54
to
f43851a
Compare
GuySartorelli
commented
Oct 23, 2024
| $renderWith = SSViewer::chooseTemplate($templates); | ||
| return $navigator->renderWith($renderWith); | ||
| return $navigator->renderWith($templates); |
There was a problem hiding this comment.
This gives the exact same result. There was no need for the chooseTemplate() there inbetween (which is good 'cause we can't do that anymore)
GuySartorelli
commented
Oct 23, 2024
Comment on lines
-904
to
910
| * Return appropriate template(s) for this class, with the given suffix using | ||
| * Return appropriate template candidates for this class, with the given suffix using | ||
| * {@link SSViewer::get_templates_by_class()} | ||
| * | ||
| * @param string $suffix | ||
| * @return string|array | ||
| */ | ||
| public function getTemplatesWithSuffix($suffix) | ||
| public function getTemplatesWithSuffix(string $suffix): array | ||
| { | ||
| $templates = SSViewer::get_templates_by_class(get_class($this), $suffix, __CLASS__); | ||
| return SSViewer::chooseTemplate($templates); | ||
| return SSViewer::get_templates_by_class(get_class($this), $suffix, __CLASS__); | ||
| } |
There was a problem hiding this comment.
This used to give specific absolute file paths to templates.
We can't do that anymore, because a) some template engines might not support that, and b) we don't want to pass a .ss template path to a twig template engine for example.
Thankfully, everywhere that used this doesn't actually need full absolute file paths. They just need some template candidates, and the ability to ask the configured engine if it can find files from those candidates or not.
emteknetnz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies and reflects on changes in silverstripe/silverstripe-framework#11405
Issue