Skip to content

Commit

Permalink
Fix comment replies being duplicated during S/R
Browse files Browse the repository at this point in the history
Turns out it was quite simple: the reply GUIDs weren't being tracked by
PHP and sent to the Javascript frontend, so when the frontend created a
new reply and updated the entire list of replies, it sent a list with no
GUIDs in it. Simply keeping track of the reply GUIDs in PHP is enough to
get rid of this bug.


Former-commit-id: 9213336
  • Loading branch information
rmunn committed Mar 26, 2018
1 parent 75217dd commit c722da6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Api/Model/Languageforge/Lexicon/LexCommentReply.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ public function __construct($content = '')
/** @var string */
public $id;

/** @var string */
public $guid;

/** @var boolean */
public $isDeleted;
}

0 comments on commit c722da6

Please sign in to comment.