Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor cleanup #1358

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Blazor cleanup #1358

merged 6 commits into from
Jan 10, 2025

Conversation

hahn-kev
Copy link
Collaborator

Fixes a number of issues

  • opening a project shows a blank screen for a while
  • sometimes a project can show the data from the previous page that was opened
  • closing FwLite desktop would not properly close FwData projects leaving a lock file in place
  • closing FwLite desktop would throw an error
  • fwdata changes were not always saved after every change

the main change here is the introduction of the IMiniLcmApiProvider, this is a simple class that let's the frontend await a promise which resolves to the API being injected. Usually provided by CrdtProject.razor or FwdataProject.razor. This is instead of polling for the API which was much slower and prone to bugs.

An open problem is still that if open a project and immediately go back, you will get an error due to trying to invoke functions on a disposed reference

Copy link

github-actions bot commented Jan 10, 2025

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit dfd970a. ± Comparison against base commit a851a66.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 10, 2025

C# Unit Tests

103 tests  ±0   103 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit dfd970a. ± Comparison against base commit a851a66.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev mentioned this pull request Jan 10, 2025
11 tasks
@hahn-kev hahn-kev merged commit 2499cd6 into develop Jan 10, 2025
24 checks passed
@hahn-kev hahn-kev deleted the chore/ioc-cleanup branch January 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant