Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New home fw lite for mobile #1351

Merged
merged 21 commits into from
Jan 9, 2025
Merged

New home fw lite for mobile #1351

merged 21 commits into from
Jan 9, 2025

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Jan 8, 2025

simulated mobile screenshot
Screen Shot 2025-01-08 at 15 39 47

also lets the user create an example project from the home page, this lets them play around with and edit data in a real project which is only local to their device.

@hahn-kev hahn-kev requested a review from myieye January 8, 2025 08:41
Copy link

github-actions bot commented Jan 8, 2025

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5673ee5. ± Comparison against base commit be8253c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 8, 2025

C# Unit Tests

103 tests  ±0   103 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5673ee5. ± Comparison against base commit be8253c.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev mentioned this pull request Jan 7, 2025
33 tasks
@myieye
Copy link
Contributor

myieye commented Jan 8, 2025

Did some tweaking. Got anchor ListItem styles working:
image
image

Everything feels very squashed together. Not just in terms of margins, but more so in terms of the different kinds of things here without any explanatory context, but I can't figure out what should change.

@hahn-kev
Copy link
Collaborator Author

hahn-kev commented Jan 9, 2025

nice! Funny I got feedback from my wife on the same thing, so I've got some fixes for that coming I think. Take a look at this
Screen Shot 2025-01-09 at 11 05 49

I changed the title from FwLite, to Projects as that's the main subject of the screen. I also added the feedback button here (and fixed as it was assuming a web server was running)

I then styled the sub titles for each section and made a bit more spacing to make them distinct. I still think a logo in the top left would look good, but that's TBD

@myieye
Copy link
Contributor

myieye commented Jan 9, 2025

Did some more tweaking.

Dektop:
image

Mobile:
image

@myieye myieye merged commit a851a66 into develop Jan 9, 2025
21 checks passed
@myieye myieye deleted the new-home-fw-lite branch January 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants