Make sync API consistent: always (before, after) #1303
Merged
+97
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmunn
force-pushed
the
chore/consistent-sync-api-before-after
branch
from
613a1cd to
f30a2db
Compare
myieye
force-pushed
the
chore/consistent-sync-api-before-after
branch
from
f30a2db to
95bde8a
Compare
myieye
force-pushed
the
chore/consistent-sync-api-before-after
branch
from
95bde8a to
26dd0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update all call sites so that code behavior remains the same.
Fixes #1293.
This is #1301 rebased on top of #1267 now that #1267 is the only open PR that touches the update API.