No more unnecessary empty "stderr:" lines in log #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
approved these changes
Aug 27, 2024
rmunn
force-pushed
the
feature/no-duplicate-output
branch
from
522bf9f to
7a649c6
Compare
rmunn
force-pushed
the
feature/less-log-spam
branch
from
4a5a201 to
62147f9
Compare
Many times stderr's contents are just a single newline; there's no need to write that to the progress log. We also don't need to write double newlines to the log, so trim the final trailing newline before writing.
rmunn
force-pushed
the
feature/less-log-spam
branch
from
62147f9 to
33c812a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times stderr's contents are just a single newline; there's no need to write that to the progress log. We also don't need to write double newlines to the log, so trim the final trailing newline before writing.
Fixes #348.
This change is