Also build for net8.0 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files + 2 404 suites +202 2h 45m 10s ⏱️ + 1h 22m 15s Results for commit 8fe98b5. ± Comparison against base commit 04eda79. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
v2.1.0 was still trying to build against win7-x32 runtimes, which are no longer offered in .NET 8. If we're using recent .NET, we need a recent setup-dotnet version.
The tests take two hours to run now that we have net461, net6.0, and net8.0 target frameworks. They're all passing except for one that's known to be flaky and timing-dependant, so it's safe to disable them while we work on fixing the part of the build that comes after the tests. Then once that's working we'll revert this commit.
This reverts commit 376030a.
The GitHub Actions runners are apparently slow to deliver filesystem notifications, which is exactly the scenario that makes this test useless. It's already disabled on Windows; there's no reason for it to cause the CI build to fail all the time when it's the only failing test.
ermshiperete
previously requested changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LfMerge wants to move to run on net8.0 rather than net6.0; this will require a chorusmerge build that can run on net8.0.
This change is