Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example #194

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Add example #194

merged 5 commits into from
Aug 25, 2023

Conversation

zsluedem
Copy link
Collaborator

Add some examples about simple account

These are some codes I used to debug. Maybe it would be helpful to add into examples.

Vid201
Vid201 requested changes Aug 14, 2023
View reviewed changes
examples/simple_account/deposit.rs Outdated Show resolved Hide resolved
examples/simple_account/transfer.rs Outdated Show resolved Hide resolved
examples/Cargo.toml Outdated Show resolved Hide resolved
@zsluedem zsluedem requested a review from Vid201 August 15, 2023 01:21
Vid201
Vid201 approved these changes Aug 15, 2023
View reviewed changes
examples/Cargo.toml Outdated Show resolved Hide resolved
@Vid201
Copy link
Member

Vid201 commented Aug 17, 2023

@zsluedem there is some lint problem

@zsluedem
Copy link
Collaborator Author

@zsluedem there is some lint problem

That's actually some build problem which relates to #188

@Vid201 Vid201 linked an issue Aug 19, 2023 that may be closed by this pull request
Examples - creating a simple account and sending first user operation #146
Closed
@zsluedem
Copy link
Collaborator Author

@Vid201 I don't know how previous dep problems could be resolve by rebase. But it is good now and please take another look.

Vid201
Vid201 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That's fine, good job

@zsluedem zsluedem merged commit 7367505 into silius-rs:main Aug 25, 2023
2 checks passed
@zsluedem zsluedem deleted the add-example branch August 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples - creating a simple account and sending first user operation
2 participants
@zsluedem @Vid201