Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI with empty initial properties. Fix:#1543 (partially) #1573

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

oliviermgx
Copy link
Contributor

@oliviermgx oliviermgx commented Apr 3, 2024

Fixing issue #1543 (partially)
All properties managed by Silex in right panel will be set to empty at initial state.
Property general>display in right panel generated by grapesjs is removed (editor.StyleManager.removeProperty) then add (editor.StyleManager.addProperty) for test purpose, waiting decision with Grapesjs team to follow this policy or not.
All others properties managed by Grapesjs are non modified waiting Grapesjs decision.

Copy link
Member

@lexoyo lexoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 🎆
Just 2 spaces to remove
Also do you check with npm run lint before you make a PR? That's a good practice
Thank you !!!

src/ts/client/grapesjs/css-props.ts Outdated Show resolved Hide resolved
src/ts/client/grapesjs/css-props.ts Outdated Show resolved Hide resolved
without undesired spaces
@oliviermgx oliviermgx requested a review from lexoyo April 3, 2024 14:15
@oliviermgx
Copy link
Contributor Author

Thank you for your comments and help !

@oliviermgx
Copy link
Contributor Author

it's seems that npm run lint has been tested during automated Github check process ?
Run with no pb on my side.

@oliviermgx oliviermgx changed the title UI with empty initial properties UI with empty initial properties. Fix:#1543 (partially) Apr 3, 2024
@lexoyo lexoyo merged commit 58dcc29 into silexlabs:dev Apr 3, 2024
2 checks passed
@lexoyo
Copy link
Member

lexoyo commented Apr 3, 2024

Aweaome 🙌🙌🙌
Fix #1543

@oliviermgx oliviermgx deleted the default_prop_empty branch April 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants