fix typing issue

silesky · Jan 2, 2022 · e05ff99 · e05ff99
1 parent fdf6287
commit e05ff99
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -128,6 +128,13 @@ export class JsonRpcClient<Api extends JsonRpcApi = EmptyObject> {
     configOverrides?: Partial<JsonRpcCreateConfig>
   ): Promise<Either<JsonRpcError, GetResponseFromContract<Api, M>>>;
 
+  async exec<M extends keyof Api = any>(
+    method: GetParamsFromContract<Api, M> extends undefined ? M : never,
+    params?: undefined,
+    id?: string,
+    configOverrides?: Partial<JsonRpcCreateConfig>
+  ): Promise<Either<JsonRpcError, GetResponseFromContract<Api, M>>>;
+
   async exec<Response>(
     method: Api extends EmptyObject ? string : never, // maybe add a branded type??
     params?: JsonRpcParams,
@@ -147,7 +154,7 @@ export class JsonRpcClient<Api extends JsonRpcApi = EmptyObject> {
    */
   async exec(
     method: string,
-    params: JsonRpcParams,
+    params?: JsonRpcParams,
     id?: string,
     configOverrides?: Partial<JsonRpcCreateConfig>
   ) {

diff --git a/test/client.test.ts b/test/client.test.ts
@@ -22,6 +22,7 @@ describe("contracts", () => {
       name: string;
     };
     type MyApiContract = {
+      GetThingWithNoParams: () => GetFooResponseDto;
       getFoo: (params: GetFooRequestDto) => GetFooResponseDto;
       getBar: (params: { age: number }) => { bar: string };
     };
@@ -38,9 +39,12 @@ describe("contracts", () => {
       expect(response.result.name).toBe(fixtures.withSuccess.payload.name);
     }
 
+    // should be no error
+    newClient.exec("GetThingWithNoParams"); // should not have params
+
     /** dtslint example */
     // @ts-expect-error
-    newClient.exec("getFoo"); // no params
+    newClient.exec("getFoo"); // no params -- should have params
 
     // @ts-expect-error
     newClient.exec("getBar", { fooId: 123 }); // wrong params