Implement getBlobSidecars support for PeerDAS
#6755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
peerdas-get-blob-sidecars
branch
from
573342d to
a9537f9
Compare
jimmygchen
commented
Jan 7, 2025
dapplion
reviewed
Jan 7, 2025
pawanjay176
reviewed
Jan 8, 2025
pawanjay176
approved these changes
Jan 8, 2025
pawanjay176
added
ready-for-merge
|
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7ec748a |
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #6251 .
Proposed Changes
The
getBlobSidecarsendpoint now serves blob sidecars on PeerDAS-enabled networks. For this endpoint to work on PeerDAS, the server needs to be custodying more than 50% of data columns. This means the node would either need to be a supernode (--subscribe-all-data-column-subnets) or have more than 64 validators attached to it. (validator custody not implemented yet)