Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electra spec changes for v1.5.0-alpha.10 #6731

Open
wants to merge 16 commits into
base: unstable
Choose a base branch
from
Open

Electra spec changes for v1.5.0-alpha.10 #6731

wants to merge 16 commits into from
+741 −340

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Dec 19, 2024 •
edited
Loading

Proposed Changes

Consensus changes for v1.5.0-alpha.10 spec WIP.

Additional Info

Work in progress.

Built on:

Blocked on:

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress consensus An issue/PR that touches consensus code, such as state_processing or block verification. electra Required for the Electra/Prague fork electra-alpha10 Electra release for devnet 5 labels Dec 19, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@michaelsproul michaelsproul mentioned this pull request Dec 19, 2024
Open
@michaelsproul
Copy link
Member Author

I think I've made all the substantial changes for Electra, but the tests are broken and I haven't looked into why. Some of them probably need disabling because this branch doesn't have the PeerDAS changes.

I'll be back on Jan 6.

@michaelsproul michaelsproul mentioned this pull request Jan 2, 2025
Closed
eserilev and others added 8 commits January 2, 2025 11:09
@eserilev
Rename PendingPartialWithdraw index field to validator_index
293db28
@eserilev
Skip slots to get test to pass and add TODO
9b8a25f
@eserilev
Implement "Synchronously check all transactions to have non-zero length"
23d331b
@eserilev
Implement "bump minimal preset MAX_BLOB_COMMITMENTS_PER_BLOCK and KZG…
251bca7 
…_COMMITMENT_INCLUSION_PROOF_DEPTH"
@eserilev
Implement "Remove post-altair initialize_beacon_state_from_eth1 fro…
3d3bc6d 
…m specs"
@michaelsproul
Update preset YAML
2dbd3b7
@michaelsproul
Make max_blobs_per_block a config parameter (#6329)
3b788bf 
Squashed commit of the following:

commit 04b3743
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 17:36:58 2025 +1100

    Add test

commit 440e854
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 17:24:50 2025 +1100

    Move RuntimeFixedVector into module and rename

commit f66e179
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 17:17:17 2025 +1100

    Fix release tests

commit e4bfe71
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 17:05:30 2025 +1100

    Thread through ChainSpec

commit 063b79c
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 15:32:16 2025 +1100

    Try fixing tests

commit 88bedf0
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 15:04:37 2025 +1100

    Revert "Remove footgun function"

    This reverts commit de01f92.

commit 32483d3
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 15:04:32 2025 +1100

    Fix typo

commit 2e86585
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 15:04:15 2025 +1100

    Move from preset to config

commit 1095d60
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 14:38:40 2025 +1100

    Minor simplifications

commit de01f92
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 14:06:57 2025 +1100

    Remove footgun function

commit 0c2c8c4
Merge: 21ecb58 f51a292
Author: Michael Sproul <[email protected]>
Date:   Mon Jan 6 14:02:50 2025 +1100

    Merge remote-tracking branch 'origin/unstable' into max-blobs-preset

commit f51a292
Author: Daniel Knopik <[email protected]>
Date:   Fri Jan 3 20:27:21 2025 +0100

    fully lint only explicitly to avoid unnecessary rebuilds (#6753)

    * fully lint only explicitly to avoid unnecessary rebuilds

commit 7e0cdde
Author: Akihito Nakano <[email protected]>
Date:   Tue Dec 24 10:38:56 2024 +0900

    Make sure we have fanout peers when publish (#6738)

    * Ensure that `fanout_peers` is always non-empty if it's `Some`

commit 21ecb58
Merge: 2fcb293 9aefb55
Author: Pawan Dhananjay <[email protected]>
Date:   Mon Oct 21 14:46:00 2024 -0700

    Merge branch 'unstable' into max-blobs-preset

commit 2fcb293
Author: Pawan Dhananjay <[email protected]>
Date:   Fri Sep 6 18:28:31 2024 -0700

    Fix test from unstable

commit 12c6ef1
Author: Pawan Dhananjay <[email protected]>
Date:   Wed Sep 4 16:16:36 2024 -0700

    Fix some more tests

commit d37733b
Author: Pawan Dhananjay <[email protected]>
Date:   Wed Sep 4 12:47:36 2024 -0700

    Fix test compilations

commit 52bb581
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Sep 3 18:38:19 2024 -0700

    cleanup

commit e71020e
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Sep 3 17:16:10 2024 -0700

    Fix take impl on RuntimeFixedList

commit 13f9bba
Merge: 60100fc 4e675cf
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Sep 3 16:08:59 2024 -0700

    Merge branch 'unstable' into max-blobs-preset

commit 60100fc
Author: Pawan Dhananjay <[email protected]>
Date:   Fri Aug 30 16:04:11 2024 -0700

    Fix some todos

commit a9cb329
Author: Pawan Dhananjay <[email protected]>
Date:   Fri Aug 30 15:54:00 2024 -0700

    Use empty_uninitialized and fix warnings

commit 4dc6e65
Author: Pawan Dhananjay <[email protected]>
Date:   Fri Aug 30 15:53:18 2024 -0700

    Add restrictions to RuntimeVariableList api

commit 25feedf
Author: Pawan Dhananjay <[email protected]>
Date:   Thu Aug 29 16:11:19 2024 -0700

    First pass
@michaelsproul
Implement max_blobs_per_block_electra
0f26408
michaelsproul
michaelsproul commented Jan 7, 2025
View reviewed changes
consensus/fork_choice/tests/tests.rs
// TODO(electra) The shuffling calculations changed between Altair and Electra. Without
// skipping slots this test breaks. For some reason `fork_name_unchecked` returns Altair
// initially, even though this test harness should be initialized with the most recent fork, i.e. Electra
.skip_slots(32)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I should look into this

@michaelsproul
Copy link
Member Author

I've squash merged the max blobs PR:

We should merge that to unstable first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked consensus An issue/PR that touches consensus code, such as state_processing or block verification. electra Required for the Electra/Prague fork electra-alpha10 Electra release for devnet 5 work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsproul @CLAassistant @eserilev