Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better assert message in lookup sampling test #6473

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Better assert message in lookup sampling test #6473

merged 5 commits into from
Oct 17, 2024

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Oct 8, 2024

Issue Addressed

Debugging a sampling failed test in #6398 it is hard to identify which specific column and request had the wrong state since there's an assert! statement without more metadata.

Proposed Changes

Log which specific sampling request and column has an unexpected state

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Oct 8, 2024
jimmygchen
jimmygchen requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment above!

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 9, 2024
@dapplion dapplion requested a review from jimmygchen October 10, 2024 13:37
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 10, 2024
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 11, 2024
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 11, 2024
@dapplion dapplion requested a review from jimmygchen October 11, 2024 08:53
jimmygchen
jimmygchen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 11, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Oct 17, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a61b587

mergify bot added a commit that referenced this pull request Oct 17, 2024
@mergify
Merge of #6473
b2c00ce
This was referenced Oct 17, 2024
Closed
Merged
Merged
@mergify mergify bot merged commit a61b587 into sigp:unstable Oct 17, 2024
29 checks passed
@dapplion dapplion deleted the lookup-sampling-test-assert branch October 17, 2024 06:53
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@dapplion @chong-he
Better assert message in lookup sampling test (sigp#6473)
ef8c854 
* Better assert message in lookup sampling test

* Export status

* Merge remote-tracking branch 'sigp/unstable' into lookup-sampling-test-assert

* Drop unused

* Use slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dapplion @michaelsproul @jimmygchen