Electra updates for v1.5.0-alpha.6 #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
force-pushed
the
electra-updates
branch
from
4b7428e to
65bac11
Compare
pawanjay176
added
electra
pawanjay176
force-pushed
the
electra-updates
branch
from
aacad31 to
33c1b2c
Compare
pawanjay176
added
ready-for-review
ethDreamer
requested changes
Oct 10, 2024
beacon_node/execution_layer/src/engine_api/new_payload_request.rs
Outdated
Show resolved
Hide resolved
michaelsproul
approved these changes
Oct 15, 2024
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 83d5c52 |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Update process_slashing * Update test vectors version * Delete Domain::Consolidation * Rename to get_max_effective_balance * Fix unused; lint * Add the pre-electra slashing processing * lint * Change request json types * Move requests from payload to beacon block body * Refactor engine api * Fix warnings * Update engine api to latest * engine api changed..again * yet again * Merge branch 'engine-requests' into electra-updates * Fix tests * Store reference instead of bytes in NewPayloadRequest * Merge branch 'unstable' into electra-updates * Update beacon_node/execution_layer/src/engine_api/json_structures.rs Co-authored-by: Michael Sproul <[email protected]> * Update beacon_node/execution_layer/src/lib.rs Co-authored-by: Michael Sproul <[email protected]> * Update beacon_node/execution_layer/src/test_utils/handle_rpc.rs Co-authored-by: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
process_single_slashingfunction instead of creating a new function for electra as I think both the pre-electra and electra functions have the same logic. I'm not completely sure if we need to make a separate >= Electra function and keep the pre-electra logic as is.Edit: Confirmed that we need different behaviour for pre and post electra. Modified in
65bac11
get_validator_max_effective_balancesimplify name of helperget_validator_max_effective_balanceethereum/consensus-specs#3909Remaining spec updates for electra are cosmetic
Blocked on #6435 for EF tests to pass.Merged #6435 into this PR to get the tests passing.