Upgrade httpcomponents #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Apr 18, 2024
| @@ -39,7 +41,7 @@ private static class SSLConnectionSocketFactoryWithTimeout extends SSLConnection | |||
| private final int timeoutMs; | |||
|
|
|||
| public SSLConnectionSocketFactoryWithTimeout(int timeoutMs) { | |||
| super(SSLContexts.createDefault(), SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER); | |||
There was a problem hiding this comment.
I couldn't find an equivalent of this in httpclient5. Could use a recommendation.
|
Well, it's here if we ever want to revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the 4.x branch of httpclient hasn't seen a release since Nov. 2022. This is old dependency is causing vulnerabilities to be detected, by way of an old version of
commons-codec(see here).This is a breaking change for any user that might have been using the (public)
RetryStrategyclass directly. Most likely that class should not have been public to begin with.