Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts sharing logic improvements #13915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Device Realme GT Neo 3t, Android 14
  • Device Infinix Hot 20 Pro, Android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

A contact can be saved in the device contacts without the name, without the number, and email. A contact is considered valid if we can reach them out by any means whether it is phone or email.

This PR includes two improvements:

  1. With the current implementation, we can share a contact as a valid contact even if it does not have a phone and an email. This PR fixes that.
  2. A contact without a name should be considered valid, for cases where the name might not be present or the user may not want to share their saved weird names.

Screenshots:

Currently present invalid shared contact:

photo_6071122296975769469_y

After improvements, a contact with no name and only number:
The saved contact didn't have any name but just the contact number

photo_6071122296975769470_y

Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, thanks! It'll go in 7.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants