Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#926): correct and clarify Guest Mode #929

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

phoenix-ru
Copy link
Collaborator

πŸ”— Linked issue

Closes #926

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There could have been a breaking change with unauthenticatedOnly, but I avoided it by defaulting to true when it's not set (compatibility behaviour) and emitting a console warning.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@sidebase/nuxt-auth@929

commit: a5fce3e

@phoenix-ru phoenix-ru merged commit 1aa5e17 into main Oct 17, 2024
7 checks passed
@phoenix-ru phoenix-ru deleted the fix/926-clarify-guest-mode branch October 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

definePageMeta({ auth: {} }) disables auth for the page
2 participants