Merge pull request WING-NUS#197 from nguyen-mai-huong/master

fix bug: failed to create guest entry the first time when guest just …
sibinhho99 · Aug 5, 2022 · ada8bcf · ada8bcf
2 parents 971d209 + f04dad5
commit ada8bcf
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/controllers/submission_logs_controller.rb b/app/controllers/submission_logs_controller.rb
@@ -49,10 +49,11 @@ def view_similarity
       if membership.nil?
         # Create a guest membership for current user
         CoursesService.create_guest_membership(course, @user)    
-      end
-
-      if membership && membership.role == UserCourseMembership::ROLE_GUEST && has_guest_detail.nil?
         CoursesService.create_guest_detail_entry(@assignment, @user)
+      else
+        if membership.role == UserCourseMembership::ROLE_GUEST && has_guest_detail.nil?
+          CoursesService.create_guest_detail_entry(@assignment, @user)
+        end
       end
     end