Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash that has been reported in #659 by disabling the window list #696

Merged
merged 3 commits into from
Sep 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bin/shutter
Original file line number Diff line number Diff line change
Expand Up @@ -8441,7 +8441,15 @@ sub STARTUP {
$menu_windows->append($active_window_item);
$menu_windows->append(Gtk3::SeparatorMenuItem->new);

# Check if we can retrieve the list of stacked windows first, otherwise we will run into a crash, see issue 659

unless ($wnck_screen->get_windows_stacked) {
print "ERROR: The window list could not be retrieved and has been disabled, see https://github.com/shutter-project/shutter/issues/659";
return $menu_windows;
}

#add all windows to menu to capture it directly

foreach my $win (@{$wnck_screen->get_windows_stacked}) {
if ($active_workspace && $win->is_on_workspace($active_workspace)) {
my $win_name = $win->get_name;
Expand Down
Loading