Test: Add syntax tests and add missing use warnings (#712)

* Test: Add syntax tests and add missing use warnings

* Test: Add missing test dependency

* Test: Drop fancy tilde in test file name. Order is not so important

* Simplify syntax test

* Remove unused modules

cpanfile

@@ -18,3 +18,4 @@ requires "File::Copy::Recursive";
 requires "Moo", ">= 2.0";
 
 test_requires "Test::MockModule";
+test_requires "Test::Strict";

share/shutter/resources/modules/Shutter/App/AboutDialog.pm

@@ -26,6 +26,7 @@ package Shutter::App::AboutDialog;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 use Gtk3;
 
 #Glib

share/shutter/resources/modules/Shutter/App/GlobalSettings.pm

@@ -26,6 +26,7 @@ package Shutter::App::GlobalSettings;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 
 #Glib
 use Glib qw/TRUE FALSE/;

share/shutter/resources/modules/Shutter/App/HelperFunctions.pm

@@ -26,6 +26,7 @@ package Shutter::App::HelperFunctions;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 use Gtk3;
 
 #Glib

share/shutter/resources/modules/Shutter/App/Menu.pm

@@ -26,6 +26,7 @@ package Shutter::App::Menu;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 use Gtk3;
 
 #Glib

share/shutter/resources/modules/Shutter/App/Optional/Exif.pm

@@ -26,6 +26,7 @@ package Shutter::App::Optional::Exif;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 
 use Glib qw/TRUE FALSE/;
 

share/shutter/resources/modules/Shutter/App/Toolbar.pm

@@ -26,6 +26,7 @@ package Shutter::App::Toolbar;
 #--------------------------------------
 use utf8;
 use strict;
+use warnings;
 use Gtk3;
 
 #Glib

share/shutter/resources/modules/Shutter/Upload/FTP.pm

@@ -24,6 +24,7 @@ package Shutter::Upload::FTP;
 
 use utf8;
 use strict;
+use warnings;
 use Net::FTP;
 use URI;
 use URI::Split qw(uri_split);

share/shutter/resources/modules/Shutter/Upload/Shared.pm

@@ -25,6 +25,7 @@ package Shutter::Upload::Shared;
 
 use utf8;
 use strict;
+use warnings;
 use POSIX qw/setlocale/;
 use Locale::gettext;
 use Glib qw/TRUE FALSE/;

share/shutter/resources/modules/X11/Protocol/Ext/XFIXES.pm

@@ -20,6 +20,7 @@ BEGIN { require 5 }
 package X11::Protocol::Ext::XFIXES;
 use X11::Protocol 'padded';
 use strict;
+use warnings;
 use Carp;
 
 use vars '$VERSION', '@CARP_NOT';

t/syntax.t

@@ -0,0 +1,19 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use Test::More;
+use Test::Strict;
+
+use FindBin qw/$Bin/;
+
+# Check syntax, use strict and use warnings on all perl files
+
+local $Test::Strict::TEST_WARNINGS = 1;
+
+my @dirs  = ('t', 'bin', "$Bin/../share/shutter/resources/modules/");
+
+all_perl_files_ok(@dirs);
+
+done_testing;