auth: Move signature from url to header

Signed-off-by: shengyong002 <[email protected]>
shuoranliu · Dec 6, 2021 · 8295b08 · 8295b08
1 parent 5a4a9d8
commit 8295b08
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/master/auth.go b/master/auth.go
@@ -31,11 +31,14 @@ type FilterFunc func(signs []*proto.AuthSignature, item interface{}) AuthHandle
 type ModifyFunc func(item interface{}) interface{}
 
 func (m *Server) parseSignatures(r *http.Request) (signs []*proto.AuthSignature, err error) {
-	if err = r.ParseForm(); err != nil {
-		return
+	signature := r.Header.Get(signatureHeaderKey)
+	if signature == "" {
+		if err = r.ParseForm(); err != nil {
+			return
+		}
+		signature = r.FormValue(signatureKey)
 	}
 
-	signature := r.FormValue(signatureKey)
 	if signature == "" {
 		return
 	}

diff --git a/master/const.go b/master/const.go
@@ -53,6 +53,7 @@ const (
 	dpSelectorNameKey       = "dpSelectorName"
 	dpSelectorParmKey       = "dpSelectorParm"
 	signatureKey            = "signature"
+	signatureHeaderKey      = "X-CBFS-Signature"
 )
 
 const (

diff --git a/sdk/master/client.go b/sdk/master/client.go
@@ -202,7 +202,7 @@ func (c *MasterClient) generateSignature(r *request) (err error) {
 		return
 	}
 
-	r.addParam("signature", string(signature[:]))
+	r.addHeader("X-CBFS-Signature", string(signature[:]))
 	return
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     		return
     	}
-    	r.addParam("signature", string(signature[:]))
+    	r.addHeader("X-CBFS-Signature", string(signature[:]))
     	return
     }
@@ Expand Down @@