Update parent-pom, run with Java 8, ci build on 2.0.0-X branch #117
Conversation
stbischof
commented
May 27, 2024
stbischof
commented
- jboss-parent from 16 to 39
- rm maven-enforcer-plugin with
- requireMavenVersion >2.2.0
- requireJavaVersion 1.5.0
- rm java5 surefire test
- fix checkstyle in code and xml
- add dependabot
- add ci build
- jboss-parent from 16 to 39 - rm maven-enforcer-plugin with - requireMavenVersion >2.2.0 - requireJavaVersion 1.5.0 - rm java5 surefire test - fix checkstyle in code and xml - add dependabot - add ci build
|
@petrberan please review and merge. |
| <version>1.6.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
The indentation seems a bit off, can you fix it @stbischof ?
| @@ -141,7 +130,7 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <!-- Testing --> | |||
| <!-- Testing --> | |||
| @@ -26,5 +26,5 @@ | |||
| * @author <a href="mailto:[email protected]">Ralf Battenfeld</a> | |||
| */ | |||
| public interface Filter { | |||
| boolean filter(final Metadata metadata, final TreeWalker walker); | |||
| boolean filter(Metadata metadata, TreeWalker walker); | |||
There was a problem hiding this comment.
I'd probably keep this PR related to updating JDK and poms, code changes could be in a different PR
| @@ -51,7 +51,7 @@ final class Pattern { | |||
| * @throws IllegalArgumentException | |||
| * If the name is not specified | |||
| */ | |||
| public Pattern(final String name) throws IllegalArgumentException { | |||
| Pattern(final String name) throws IllegalArgumentException { | |||
There was a problem hiding this comment.
Same thing, let's keep this PR focused on JDK and poms
|
|
||
| on: | ||
| push: | ||
| branches: [ "2.0.0-X" ] |
There was a problem hiding this comment.
Now that 2.0.0-X was renamed this should be "main"
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2 |
There was a problem hiding this comment.
First time I see this, any preference over using the standard @v4?
There was a problem hiding this comment.
Fix the version on its commit hash. @4 is Always the latest of 4
Makes a reproducable build.
Is recommend from some open source Security observers.
Dependabot can handle the Updates also.
There was a problem hiding this comment.
Got it, fine by me. Feel free to have a look at the rest of the comments and we can get this merged 👍
