Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing localisation texts #63

Closed
wants to merge 1 commit into from

Conversation

craig-johnston
Copy link

@craig-johnston craig-johnston commented Feb 28, 2024

"Fixes" the localisation by skipping over the "?" in the localisation list
The code also returns nothing instead of the localisation key if it can't find it (matches Factorio behaviour)
Trims the start of the localisation string to avoid empty lines caused by the aforementioned.

FWIW, I don't think it s OK to merge as-is, but I wanted to show that this does fix a number of localisation issues. Just need to work out how to do it safely/correctly.

Fixes #43

@veger veger changed the title Fix for issue43 Fix missing localisation texts Feb 29, 2024
@shihan42
Copy link
Collaborator

FWIW, I don't think it s OK to merge as-is, but I wanted to show that this does fix a number of localisation issues. Just need to work out how to do it safely/correctly.

What do you think is not correct yet in your draft?

@craig-johnston
Copy link
Author

The main thing is this magic number index into the object. I'm sure there's a better way/checks. But I don't know the best way in C#.

c04a4c4#diff-ea4b1394a7c8caf7c4ff0ce289b1a729c036db520d4b12b9c05b7624ddc0d8c3R384

@shpaass
Copy link
Owner

shpaass commented Jan 7, 2025

Based on my checks of pY:AE Bone Meal and Diesel, it seems that the issue #43 was addressed by the PR #329.
@craig-johnston, thank you for the example! It might be useful in the future as a reference.
I'll close the PR because the issue is resolved. Feel free to reopen if necessary.

@shpaass shpaass closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the question mark when hovering over a recipe
3 participants