Add a self-contained Windows release #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation[1], it is implied that --self-contained is true only if you specify it. It doesn't get enabled without a flag. Therefore, we don't need to specify it where we want it to be disabled. [1]: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish
veger
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a self-contained Windows deliverable.
Also removes
--self-contained falsefrom other deliverables because it is so by default. More info on that in the commit message.Testing done: Made a build before and after the refactor. The sizes of artifacts were the same.
Closes #359