Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance changes/updates #345

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Maintenance changes/updates #345

merged 15 commits into from
Nov 5, 2024

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Nov 5, 2024

I got tired of seeing complaints that we're using nuget packages that have vulnerabilities (transitively via xUnit), and then decided to fix some (a lot of?) other suggestion-level noise that keeps popping up in VS.

I've done some development based on this, but the only things I was concerned enough about to explicitly check were the xUnit upgrade and the Shevron->Chevron rename.

@DaleStan DaleStan requested a review from shpaass as a code owner November 5, 2024 16:25
@shpaass
Copy link
Owner

shpaass commented Nov 5, 2024

Thank you for the fixes!
I thought I got most of them in my previous Code Cleanup PRs, but it seems like there's more.
I was especially surprised that we had a custom hashcode implementation.

Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and since the tests passed I guess the xUnit upgrade and the Chevron rename are fine

@shpaass shpaass merged commit 5707cc5 into shpaass:master Nov 5, 2024
1 check passed
@DaleStan DaleStan deleted the maintenance branch November 6, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants