-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show total output for scrap #338
Show total output for scrap #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feature! That was fast.
I'll keep the PR open for a bit, for others to check it too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice solution, using the 'features' we already have
Code looks fine as well to me
579fe8e
to
6bc35a4
Compare
Rebased on fresh master |
Found a problem: In Pyanodons and other mods that have tons of many-out recipes, one would be incentivized to disable this feature because otherwise these stats would show on most of the recipes. We don't want it for most recipes because one never does sushi on anything unless it's forced. The current solution is to disable the feature by increasing the number. |
Or make this value configurable per project and/or an option to enable/disable completely? |
No need for such an option when it can be achieved by increasing the number to unreachable heights.
I see no need to go that deep because the per-project functionality is unlikely to be used. |
The OP mentioned:
I guess a value of '11' will block this one? (IIRC there are 6 geode colors?) That is why I was wondering to make this configurable |
Hmmm, good example. But making it per-project requires to add more persistence, which is more work. |
You mean making it a global setting? Could also work (but is the same amount of work?) |
So back to the topic/suggestion: making the default 11 If we want to let seablock/geodes work by default, then we should increase the default to 5 (or what is the number of geode colors?). Does that reduce adding I/O signals for the py mod suite, or is it still to low? |
Simple Circut board and Battery have recipes with 7 inputs. Mechanical Parts 1 is 8 inputs. |
The situation is that for pY, there are popular recipes with the number of inputs exceeding 11. We might need a per-recipe setting for this functionality, but I don't yet know where to put it on the UI. |
For a per-recipe setting, we can use the 'context menu' (where you can set the fixed building, delete, etc)? Edit We had the same thought 😄 |
You want to replace the whole |
I quickly tried, and it feels quite natural. I'll clean up a little and open a follow up PR. |
Yes, I'd want to replace the project-wide setting with the per-recipe setting. |
Thank you! I knew it would be useful, but didn't realize it would also be easy. Making the threshold adjustable is a good idea. That will work very well for Fulgora and SeaBlock. I don't know about the other planets. By project is better, so you don't lose it when you change modpacks, but it's not too hard to change. How distracting is the extra information? Is it worth separating the input and output threshold? Most multi-input recipes have a separate lane for each input so don't need the input total.
Either method would work for the modpacks I've used. Only a few recipes need the extra information (so it's easy to set for each one), and no other recipes have that many outputs (so a threshold is easy to set). |
It was not easy. It was only due to
Sufficiently distracting. Figuratively, imagine that all recipes now have an output or input item that does nothing but take space on the screen.
Not worth it. From what I remember, there are no recipes that both take that many inputs and outputs at the same time. For instance, if the setting is enabled, it only shows the input summary when the input is over the threshold. Same for the output. |
I encourage you to ask any overhaul-mod player if they did sushi when they were not forced to. You will find out that sushi is almost never used aside from being mandatory or being the voiding/conversion for all the inputs. The only example of non-forced sushi that I remember in pY is the biomass conversion. The input-sum functionality is not useful in this case. |
Apologies, you're right. |
Quick, then? Either way, many thanks!
Good point. Width is already a problem for me when I try to put the game and YAFC on side-by-side.
|
I did sushi for geodes for my 100x SeaBlock run. It worked very well. |
As discussed in #338 it might be more convenient to make the recipe total I/O configurable per recipe, sicne we cannot figure out a 'catch all' that covers all of the seablock, py and space-age, etc. mods... The screenshot shows the same recipe twice, one with I/O enabled and one disabled: ![image](https://github.com/user-attachments/assets/4f62fd0c-e65a-4f8a-be28-6c94331d6e91) *Note that the label is renamed to "Show total Input/Output"*
When drawing a recipe with several item inputs or outputs, the UI will add synthetic [I] or [O] items, representing the total sushi input or output:
The default count is three, but it can be changed in the preferences:
These synthetic items can't be linked, but you can set a fixed count for them if you want a particular number of sushi-belts of production or consumption.