-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle research trigger 'craft-item' #327
Conversation
Yafc.Parser/Data/FactorioDataDeserializer_RecipeAndTechnology.cs
Outdated
Show resolved
Hide resolved
Thanks for doing the UI work. I don't have anything against this change, but I want to explore the topic of trigger techs a bit further: For me the big challenge was to include the triggers into the tech tree / milestone analysis. Unfortunately it doesn't build up one big graph and then "simply" walks along edges and marks nodes as "available". It has some really weird logic. So I went the easy way, basically enabled all techs (by binding e.g. the MineEntityTechnologyTrigger trigger needs a lot of requirements:
To sum it up, I'm not surprised that the |
6a87300
to
e398d37
Compare
@SWeini we could add another field to the |
and improve error reporting a little for unsupported research triggers
e398d37
to
7013ed3
Compare
Rebased on fresh master |
While checking for the Space Age changes of #320, I noticed 'new' errors when loading a project. Which was triggered by the (lack of) support of the new research triggers.
Adding the
craft-item
type was fairly easy (I was fiddling a bit and it worked):<removed outdated screenshot, see comments for newer one>
So I cleaned the code a little and made this PR.
Note that supporting
mine-entity
was also easy, but for some reason it makes most of the items inaccessible... So I did not include it in this PR. We need to take a better look.The other types, I did not try as their implementation was not directly apparent to me (and
craft-fluid
is not in use, so I could not try/test)