-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve module calculation #282
Conversation
Updated wording of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate, IMO, that this still has the behavior where the best module for a vanilla automation pack is efficiency, not prod, but that's not a regression.
It also has unexpected behavior with Bob's modules (Excluding god modules: project, game), where it upgrades from speed 7 to pure speed 5.
I can't immediately come up with a rigorous way to prevent either of these, but I'm tossing them out there to see if you have any ideas.
Requesting changes for the 0 => NegativeInfinity change and the whitespace, unless someone has good ideas on fixing the above problems.
Also, please add a line to the changelog.
3af95c8
to
8c0fa76
Compare
Rebased on fresh master and added a prefix to the commit message. |
1a89d5c
to
15aa6ed
Compare
565dfd0
to
c225c7c
Compare
Rebased on fresh master |
c225c7c
to
f726baf
Compare
Add speed as a factor, so the autofiller does not discard pY-AE modules.
f726baf
to
926bee3
Compare
Squashed fixes and applied |
This PR adds speed-related module calculation into the module autofill.
The main motivation is that previously bio/alien modules did not work with autofill because they only provide speed stats and have no effect on productivity or energy.
This PR uses the cost of buildings as a way to model the benefit of using speed-related modules.
From my testing, it works well with pY and vanilla.
In vanilla, a speed module is preferred only when the payback time is less then an hour. After that, the Efficiency Modules are preferred, which is similar to the behavior before this PR.