Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show download progress when downloading patch artifacts #2563

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Updates ArtifactManager.downloadFile to accept an onProgress callback, which is used by the patch command and the android patcher to display download progress.

I hope for this to be helpful in diagnosing #2532

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tried this style of on-progress before and found it didn't work as expected (since the stream will get read in one big chunk when reading from disk iirc?), but printing here is still better than nothing and hopefully will help us diagnose.

@bryanoltman bryanoltman merged commit 4cb17a5 into main Oct 21, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/download-progress branch October 21, 2024 17:22
@bryanoltman
Copy link
Contributor Author

After testing this on a slow connection, the frequent progress updates cause an unpleasant flickering in the terminal. Going to address that in a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants