fix: Ensure that the update version is formatted correctly during the update check #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitelg
requested review from
aragon999,
mkreusch,
DennisGarding,
rathmerdominik,
PascalThesing and
ennasus4sun
|
DennisGarding
approved these changes
Oct 16, 2023
rathmerdominik
approved these changes
Oct 16, 2023
ennasus4sun
approved these changes
Oct 16, 2023
mitelg
added
Accepted
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Without the change, a leading "v" would be on the update version, which leads to errors, if this version is used for calls against the SBP
2. What does this change do, exactly?
Remove the leading "v" from the version altogether