Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop usage of xml_set_object() #2615

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Girgias
Copy link
Contributor

@Girgias Girgias commented Oct 7, 2023

1. Why is this change necessary?

Potential deprecation in PHP 8.4.

2. What does this change do, exactly?

Use normal callables instead of ext/xml's strange feature of passing a method name

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023


Fails
🚫 The commit title `Drop usage of xml_set_object()

And use normal callables instead of ext/xml's strange feature` does not match our requirements. Please follow: www.conventionalcommits.org

Warnings
⚠️ The Pull Request doesn't contain any changes to the Upgrade file

@aragon999
Copy link
Contributor

Mh, maybe we should deprecate and remove the Zend_Translate component altogether, as it is currently unused in Shopware itself and only used internally in the Zend framework as far as I can tell.

But besides that, the change looks good to me.

Can you adjust the commit message to follow the conventional commits (i.e. refactor: Drop usage of xml_set_object() ...) and accept the CLA?

@mitelg
Copy link
Contributor

mitelg commented Dec 1, 2023

hey @Girgias any progress here?

And use normal callables instead of ext/xml's strange feature
@Girgias
Copy link
Contributor Author

Girgias commented Dec 1, 2023

Mh, maybe we should deprecate and remove the Zend_Translate component altogether, as it is currently unused in Shopware itself and only used internally in the Zend framework as far as I can tell.

But besides that, the change looks good to me.

Can you adjust the commit message to follow the conventional commits (i.e. refactor: Drop usage of xml_set_object() ...) and accept the CLA?

Is it possible to not change the commit message in the merge? I didn't fork the project and just used the GitHub UI code editor to make the change and I have no idea how to achieve this in said UI.

Just signed the CLA.

@mitelg mitelg merged commit 268f77b into shopware5:5.7 Dec 4, 2023
24 of 25 checks passed
@mitelg
Copy link
Contributor

mitelg commented Dec 4, 2023

hey @Girgias
I just did that.
thanks for your contribution! 👍🎉💙

@mitelg mitelg added Accepted and removed Incomplete labels Dec 4, 2023
@Girgias Girgias deleted the remove-xml-set-object-usage branch December 4, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants