refactor: Replace sSYSTEM->sCONFIG calls in export #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @aragon999 thanks for your PR, it looks good to me 👍 please rebase your branch |
aragon999
force-pushed
the
refactor/sExport-config
branch
from
62ff28a
to
6bf4227
Compare
|
mitelg
approved these changes
Aug 24, 2023
ennasus4sun
approved these changes
Aug 24, 2023
rathmerdominik
approved these changes
Aug 24, 2023
|
thanks for your contribution @aragon999 👍🎉💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
sSystemwill be removed in Shopware 5.8, therefore we need to replace the remaining occurrences. I am not sure if this change should be considered breaking or not. As it is a public property, it could be replaced...What do you think?
2. Checklist