Fix/dc 3170 redis connect error #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis-shoplineapp
approved these changes
Jan 2, 2025
travis-shoplineapp
approved these changes
Jan 2, 2025
lib/models/App.js
Outdated
| return this | ||
| } catch (err) { | ||
| console.error('error when starting app', err); | ||
| if (this.config && this.config.app && this.config.app.throwAndStopWhenError) { |
There was a problem hiding this comment.
this should be a fix rather than needing backward compatibility, a service should not start if the dependency fail
also when a client chooses to upgrade sl-express, they should be aware our change
consider reducing code complexity
slbosco
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxRetryDelayMsconfig for redis