Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssl policy add acm-arn condition #160

Merged

Conversation

chiayu-su
Copy link
Contributor

@chiayu-su chiayu-su commented Aug 9, 2024

無 alb.ingress.kubernetes.io/certificate-arn:

helm diff upgrade api ../simple --allow-unreleased -n core

core, api, Ingress (networking.k8s.io) has changed:
  # Source: simple/templates/ingress.yaml
  apiVersion: networking.k8s.io/v1
  kind: Ingress
  metadata:
    name: api
    labels:
      businessid: "000000042493042706"
    annotations:
      alb.ingress.kubernetes.io/healthcheck-interval-seconds: "61"
      alb.ingress.kubernetes.io/healthcheck-path: /health_check
      alb.ingress.kubernetes.io/healthcheck-timeout-seconds: "60"
      alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80}]'
      alb.ingress.kubernetes.io/load-balancer-attributes: access_logs.s3.enabled=true,access_logs.s3.bucket=aws-service-logs,access_logs.s3.prefix=elb/api-production,idle_timeout.timeout_seconds=70,deletion_protection.enabled=true
      alb.ingress.kubernetes.io/load-balancer-name: alb-api-production
      alb.ingress.kubernetes.io/scheme: internal
      alb.ingress.kubernetes.io/target-group-attributes: load_balancing.algorithm.type=least_outstanding_requests
      alb.ingress.kubernetes.io/target-type: ip
      kubernetes.io/ingress.class: alb
+     alb.ingress.kubernetes.io/tags: "businessid=000000042493042706"
  spec:
    rules:
      -
        host: "api-production-pre-render.internal.shopline"
        http:
          paths:
          - backend:
              service:
                name: pre-render-api
                port:
                  name: pre-render-api
            path: /*
            pathType: ImplementationSpecific
      -
        http:
          paths:
          - backend:
              service:
                name: api
                port:
                  name: api
            path: /*
            pathType: ImplementationSpecific

有 alb.ingress.kubernetes.io/certificate-arn:

helm diff upgrade cart-service ../simple --allow-unreleased -n cart-service

cart-service, cart-service, Ingress (networking.k8s.io) has changed:
  # Source: simple/templates/ingress.yaml
  apiVersion: networking.k8s.io/v1
  kind: Ingress
  metadata:
    name: cart-service
    labels:
      businessid: "000000042493042505"
    annotations:
      alb.ingress.kubernetes.io/backend-protocol: HTTP
      alb.ingress.kubernetes.io/backend-protocol-version: GRPC
      alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:ap-southeast-1:332947256684:certificate/30331c58-b541-4cef-9711-4f1ee58142d2
      alb.ingress.kubernetes.io/healthcheck-path: /grpc.health.v1.Health/Check
      alb.ingress.kubernetes.io/healthcheck-protocol: HTTP
      alb.ingress.kubernetes.io/listen-ports: '[{"HTTPS":443}]'
      alb.ingress.kubernetes.io/load-balancer-attributes: access_logs.s3.enabled=true,access_logs.s3.bucket=aws-service-logs,access_logs.s3.prefix=elb/cart-service-production,deletion_protection.enabled=true
      alb.ingress.kubernetes.io/load-balancer-name: cart-service-production
      alb.ingress.kubernetes.io/scheme: internal
      alb.ingress.kubernetes.io/subnets: subnet-84a883e0,subnet-f3b6ea85
      alb.ingress.kubernetes.io/success-codes: "0"
      alb.ingress.kubernetes.io/target-group-attributes: load_balancing.algorithm.type=least_outstanding_requests
      alb.ingress.kubernetes.io/target-type: ip
      kubernetes.io/ingress.class: alb
      alb.ingress.kubernetes.io/ssl-policy: "ELBSecurityPolicy-TLS13-1-2-2021-06"
+     alb.ingress.kubernetes.io/tags: "businessid=000000042493042505"
  spec:
    rules:
      -
        host: "cart-service.shoplineapi.com"
        http:
          paths:
          - backend:
              service:
                name: cart-service
                port:
                  number: 3000
            path: /*
            pathType: ImplementationSpecific

@chiayu-su chiayu-su merged commit ef659fb into shoplineapp:master Aug 9, 2024
5 checks passed
@chiayu-su chiayu-su deleted the fix/ingress-policy-only-for-https branch August 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants