Merge pull request #131 from shoplineapp/feature/PLAT-515-use-argo-bu…

…ilt-in-pdb feat(cronjob): use argo's built in support for pdb to replace custom chart
shoplineapp · Oct 26, 2023 · f3b33a2 · f3b33a2
2 parents 49aee20 + b8544a5
commit f3b33a2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/cronjob/templates/_argo_cron_workflow.tpl b/cronjob/templates/_argo_cron_workflow.tpl
@@ -60,6 +60,18 @@
     {{- if .Values.exitNotifications }}
     onExit: exit-handler 
     {{- end }}
+    {{- if .Values.pdb }}
+    {{- if eq .Values.pdb.enable true }}
+    podDisruptionBudget:
+      {{- if .Values.pdb.maxUnavailable }}
+      maxUnavailable: {{ .Values.pdb.maxUnavailable }}
+      {{- else }}
+      # Documentation: https://argoproj.github.io/argo-workflows/fields/#poddisruptionbudgetspec
+      # Provide arbitrary big number if you don't know how many pods workflow creates
+      minAvailable: {{ .Values.pdb.minAvailable | default 9999 }}
+      {{- end }}
+    {{- end }}
+    {{- end }}
     templates:
       - name: entry
         steps:

diff --git a/cronjob/templates/pdb.yaml b/cronjob/templates/pdb.yaml
diff --git a/cronjob/values.yaml b/cronjob/values.yaml
@@ -151,8 +151,8 @@ serviceaccount: {}
 suspend: false
 
 pdb:
-  # If you just set "enable: true", default will set to "minAvailable: 100%" unless you have set other parameters.
+  # If you just set "enable: true", default will set to "minAvailable: 9999" unless you have set other parameters.
   enable: false
   # Note: You can specify only one of maxUnavailable and minAvailable in a single PodDisruptionBudget, and if you setting both will only set maxUnavailable.
-  # minAvailable: 50%
-  # maxUnavailable: 50%
+  # minAvailable: 9999
+  # maxUnavailable: 0