Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/avoid n plus 1 domain #2242

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 30, 2024

Part of #2112

When listing short URLs, make sure the domain authority fetched in the main query is used instead of falling back to $shortUrl->getDomain()?->authority, which would run another SELECT from the domain just to fetch information we already have.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (36ad3a7) to head (ee32d1a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2242   +/-   ##
==========================================
  Coverage      93.53%   93.54%           
- Complexity      1611     1613    +2     
==========================================
  Files            270      270           
  Lines           5631     5635    +4     
==========================================
+ Hits            5267     5271    +4     
  Misses           364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 5b98c44 into shlinkio:develop Oct 30, 2024
31 checks passed
@acelaya acelaya deleted the feature/avoid-n-plus-1-domain branch October 30, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant