-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split reusable content into separated components #853
Merged
acelaya
merged 45 commits into
shlinkio:develop
from
acelaya-forks:feature/shlink-web-component
Aug 7, 2023
Merged
Split reusable content into separated components #853
acelaya
merged 45 commits into
shlinkio:develop
from
acelaya-forks:feature/shlink-web-component
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #853 +/- ##
===========================================
+ Coverage 84.61% 84.76% +0.15%
===========================================
Files 189 212 +23
Lines 10216 10630 +414
Branches 1442 1464 +22
===========================================
+ Hits 8644 9011 +367
- Misses 156 182 +26
- Partials 1416 1437 +21
|
acelaya
force-pushed
the
feature/shlink-web-component
branch
from
August 6, 2023 11:15
eae7eed
to
9f9f3b6
Compare
Preview environmenthttps://shlinkio.github.io/shlink-web-client/feature/shlink-web-component/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #338
Split everything that can be used on any app into
@shlinkio/shlink-web-component
package.Split frontend utils and components that are required by this app and shlink-web-component into
@shlinkio/shlink-frontend-kit
.