Remove not used coroutine import #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coroutine is removed from python since python 3.11, it's imported in the __init__.py file but not used anywhere so that can be removed safely.
|
At present, Pydle only supports Python versions 3.6-3.10, so this isn't an issue with currently supported versions, however, I agree that it appears to be unused and should be removed. Initial testing looks like Pydle (on 3.8) doesn't complain if this import is gone. Pydle does not currently support Python 3.10 or 3.11 (See issue #162 and PR #180) but this is a needed fix for when Pydle looks into 3.11 support. All in all, LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coroutine is removed from python since python 3.11, it's imported in the init.py file but not used anywhere so that can be removed safely.