[#166] Add LIST Support #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to call channel_list from the BasicClient, which returns a list containing the total LIST response from the server according to the IRC specification
theunkn0wn1
reviewed
Oct 24, 2022
Comment on lines
+77
to
+78
| except asyncio.CancelledError: | ||
| pass |
There was a problem hiding this comment.
This should likely propagate up the cancellation error, right now it unexpectedly returns None from a function that should return a list[Channel] (where Channel = str, probably)
| self._list_topic = [] | ||
| self._list_query = asyncio.Queue() | ||
|
|
||
| async def channel_list(self): |
There was a problem hiding this comment.
missing return type annotation.
Comment on lines
+63
to
+67
| self.all_channels = [] | ||
| self._list_client = [] | ||
| self._list_channel = [] | ||
| self._list_count = [] | ||
| self._list_topic = [] |
There was a problem hiding this comment.
These should get some type annotations.
Comment on lines
+71
to
+73
| await self.rawmsg("LIST") | ||
| future = asyncio.get_running_loop().create_future() | ||
| await self._list_query.put(future) |
There was a problem hiding this comment.
This future should be enqueued prior to emitting the LIST command, to prevent a race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the LIST command (defined by RFC1459 Section 4.2.6) and adds a new function (BasicClient.channel_list). The channel_list function returns an updated channel listing of all channels and details of channels generated by the LIST command.
This differs from the existing BasicClient.channels, which only return channels that Pylde is currently in, or considers itself to already be in.
Resolves #166