Fix: Warning: calls to std::mem::drop #538
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #523
What I did:
Fix warning
calls to std::mem::drop
Why the problem occurred:
The std::mem::drop function is used to drop (dispose of) a value, taking ownership of that value as its argument.
In this case, a reference (&mut File) was passed to the function.
Since std::mem::drop targets values with ownership and not references, using it on a reference does nothing.
Therefore, this call to drop was unnecessary and the cause of the warning.
Test: