Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Custom theme options tabs #93

Open
2 tasks done
SpaceEnergy opened this issue Aug 28, 2024 · 12 comments · Fixed by #94
Open
2 tasks done

[Feature] Custom theme options tabs #93

SpaceEnergy opened this issue Aug 28, 2024 · 12 comments · Fixed by #94
Labels
enhancement New feature or request released

Comments

@SpaceEnergy
Copy link

Before Requesting

  • I found no existing issue matching my feature request
  • This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!

Custom tabs that the dev can create for the theme options to make many theme options look a little bit more organized and tidy

like this:
image

Anything else?

No response

@shdwmtr
Copy link
Owner

shdwmtr commented Aug 28, 2024

Suggest a skin.json formatting you'd like to see it use.

@SpaceEnergy
Copy link
Author

{
    "Conditions": {
        "Tab name 1": {
            "Experimental": {
                "description": "Activates experimental functions (there may/will be bugs)",
                "default": "no",
                "values": {
                    "no": {},
                    "yes": {
                        "TargetCss": { "affects": ["^Steam$"], "src": "options/experimental.css" },
                        "TargetJs": { "affects": ["^Steam$"], "src": "options/experimental.js" }
                    }
                }
            }
        },
        "Tab name 2": {
            "Experimental": {
                "description": "Activates experimental functions (there may/will be bugs)",
                "default": "no",
                "values": {
                    "no": {},
                    "yes": {
                        "TargetCss": { "affects": ["^Steam$"], "src": "options/experimental.css" },
                        "TargetJs": { "affects": ["^Steam$"], "src": "options/experimental.js" }
                    }
                }
            }
        }
    }
}

Copy link

🎉 This issue has been resolved in version 2.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@SpaceEnergy
Copy link
Author

@shdwmtr @ricewind012 could you add something that if a tab is called “Colors” it is simply added to the tab with the root colors

@ricewind012
Copy link
Collaborator

i don't get it

@SpaceEnergy
Copy link
Author

SpaceEnergy commented Sep 1, 2024

I give an option in the skin.json file "tab": "Colors" or "tab": "colors" and this is then added to the top of this tab:
image

@shdwmtr
Copy link
Owner

shdwmtr commented Sep 1, 2024

@SpaceEnergy Provide your skin.json, I'm relatively sure @ricewind012 doesn't even know that exists

@shdwmtr shdwmtr reopened this Sep 1, 2024
@SpaceEnergy
Copy link
Author

@ricewind012
das: https://github.com/SpaceTheme/Steam/blob/main/skin.json#L117 wird zu einem color tab gemacht und meine frage ist nun das wenn man in einer eigenen option beim Tab namen "Colors"/"colors" eingibt das es auch in dem tab kommt wie RootColors

like this:

"System accent colors": {
            "description": "Replaces the SpaceTheme accent colors with your system accent colors",
            "default": "no",
            *"tab": "Colors"*,
            "values": {
                "no": {},
                "yes": {
                    "TargetCss": { "affects": [".*"], "src": "options/systemAccent.css" }
                }
            }
        }

image

@ricewind012
Copy link
Collaborator

you can just override them with !important, no ?

@SpaceEnergy
Copy link
Author

no that's not the problem xd
but root-colors creates a “Colors” tab and when i assign the tab “Colors” to an option a 2nd tab with the name is created and not made in the already existing one

@shdwmtr
Copy link
Owner

shdwmtr commented Oct 28, 2024

@SpaceEnergy is this solved?

@SpaceEnergy
Copy link
Author

in itself already, but I would still be happy if that still comes that if you give an option the tab name Colors that it comes with in the Colors tab so where you can set the root colors (because currently an extra tab would be created)

If this is better for you I can open an extra issue for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants