Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dropdown Checkboxes for theme options #92

Open
2 tasks done
SpaceEnergy opened this issue Aug 28, 2024 · 8 comments
Open
2 tasks done

[Feature] Dropdown Checkboxes for theme options #92

SpaceEnergy opened this issue Aug 28, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@SpaceEnergy
Copy link

Before Requesting

  • I found no existing issue matching my feature request
  • This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!

Dropdown with checkboxes inside which the user can select according to his wishes.
of course, the individual options should also be bound to a CSS or JS file

like this:
image

Anything else?

No response

@shdwmtr
Copy link
Owner

shdwmtr commented Aug 28, 2024

Suggest a skin.json formatting you'd like to see it use.

@SpaceEnergy
Copy link
Author

here i have no idea
maybe:

        "What's New": {
            "description": "Customize the What's New section",
            "default": "Compact",
            "type": "dropcheck",
            "values": {
                "Show": {},
                "Compact": {
                    "TargetCss": { "affects": ["^Steam$"], "src": "options/whatsNew/compact.css" }
                },
                "Hide": {
                    "TargetCss": { "affects": ["^Steam$"], "src": "options/whatsNew/hide.css" }
                }
            }
        }

@ricewind012
Copy link
Collaborator

closing in favor of #93, since it seems like the perfect purpose for that

@SpaceEnergy
Copy link
Author

uh? but they are 2 different things

@ricewind012
Copy link
Collaborator

what could be the difference between that and making a tab specifically for that dropdown ? it just seems redundant with tabs

@SpaceEnergy
Copy link
Author

the dropdown checkboxes have nothing to do with the tabs, these are 2 completely different requests
#93 is for tabs and #92 is for checkboxes in dropdowns

@ricewind012
Copy link
Collaborator

ricewind012 commented Aug 29, 2024

actually, this could *maybe* be repurposed to applying css properties for specific elements, i.e.

"Hide titlebar buttons": {
	"type": "checkboxdropdown",
	"description": "Removes titlebar buttons from the main window",
	"property": "display: none !important",
	"values": {
		"Big Picture": {
			"default": true,
			"selector": "._3cykd-VfN_xBxf3Qxriccm > :nth-child(4)",
			"patch": {
				"TargetCss": {
					"affects": ["^Steam$"],
				}
			}
		},
		"Steam News": {
			"default": true,
			"selector": "._3cykd-VfN_xBxf3Qxriccm > :nth-child(1)",
			"patch": {
				"TargetCss": {
					"affects": ["^Steam$"],
				}
			}
		},
	}
}

but this seems like a job for a plugin or something

@ricewind012 ricewind012 reopened this Aug 29, 2024
@shdwmtr
Copy link
Owner

shdwmtr commented Aug 29, 2024

Yeah, two very different requests, not sure what @ricewind012 is talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants