Add lookup by TVDB Id on Sonarr #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayaantx
reviewed
Apr 17, 2024
shayaantx
reviewed
Apr 17, 2024
shayaantx
requested changes
Apr 17, 2024
|
Going to take a look later today. 👍 |
|
@g-nogueira were you planning to finish this? all you need to do is push a version bump in version.txt to 5.6.14 from 5.6.13 |
|
Yep, sorry. Had a busy week. |
|
|
@shayaantx bumped |
shayaantx
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there.
I forked your project to add some things I would like and ended up implementing that TODO to lookup by tvdb id on Sonarr. From what I've searched, this is the way it's commonly done. Hope this is okay.
Breaking change
command
!show id add SHOW_TITLE_HERE SHOW_ID_HEREis now!show id add SHOW_ID_HEREOther changes
Updated the unit tests
From my tests, I was able to successfully add a show by id on Slack and all the unit tests passed.
