Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css pseudo-class syntax warning #8515

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

0xApotheosis
Copy link
Member

Description

This PR addresses a warning related to the incorrect use of CSS pseudo-class syntax in the StepperStep component. The warning was caused by the use of :last-of-type in a JavaScript object notation, which is not supported.

Issue (if applicable)

None, quick fix.

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

N/A

Testing

This warning should no longer show in the console when confirming the trade summary:

Screenshot 2025-01-09 at 10 31 01

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

See above.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 8, 2025 23:46
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally: https://jam.dev/c/2b8c7081-f12e-4b14-a0d2-32a3578f50ee

Confirmed:

  • Spew spew 🔫 is gone ✅
  • Stepper steps are still happy visually ✅

@gomesalexandre gomesalexandre enabled auto-merge (squash) January 9, 2025 07:28
@gomesalexandre gomesalexandre merged commit ebfd6f1 into develop Jan 9, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the fix-css-syntax branch January 9, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants